disco, pack: auction scheduler strategy - #12619

🟡 Changes recommended

The auction strategy is rejected by the bundled GUI’s unchanged schema, and the configuration documentation incorrectly claims votes bypass auction batching.

_{Review effort: Balanced}

🔵 Needs a closer look

The tests do not exercise bulk promotion with multiple entries, including a penalty treap, leaving transaction preservation and account-conflict enforcement unverified for the new traversal.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Test bulk promotion from treaps with shared-account conflicts

src/​disco/​pack/​test_pack.c:1755

This only promotes one held transaction; the later three-transaction case deletes or expires every entry before ending the auction. Consequently, the new traversal that clears the source treap and reinserts its nodes is never exercised with multiple entries. Please add a bulk-promotion case, including enough shared-account transactions to enter a penalty treap, then verify the pack and drain it to check that no entries are lost and account conflicts remain enforced.

_{Review effort: Balanced}

🔵 Needs a closer look

The auction-flush tests leave multi-entry traversal and conflict tracking untested; coverage should verify priority order and blocking of transactions sharing writable accounts until the preceding microblock completes.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Test multi-entry auction flush traversal and conflict tracking

src/​disco/​pack/​fd_pack.c:3025

test_next_auction flushes only one transaction; its multi-entry case deletes or expires every entry before ending the auction. This leaves multi-entry traversal and conflict tracking during the flush untested. Add a case with multiple held transactions sharing writable accounts, then verify priority order and that conflicting work stays blocked until the preceding microblock completes.

_{Review effort: Balanced}

🔵 Needs a closer look

An unpublished mismatch between the metric’s documented cutoff and its actual trigger requires human assessment of its impact on exported documentation and schema.

No open issues 🎉

_{Review effort: Balanced}

🔵 Needs a closer look

Timing-sensitive interactions among auction deadlines, CU pacing, bundle arrivals, and leader-slot transitions require representative runtime/load validation beyond the queue-focused unit test.

No open issues 🎉

_{Review effort: Balanced}

🔵 Needs a closer look

Human assessment is needed because auction-end tests leave multi-transaction transfers, shared-account allocation, and penalty handling untested, so transaction preservation and conflict enforcement remain unverified.

No open issues 🎉

_{Review effort: Balanced}

🔵 Needs a closer look

The new test leaves multi-node auction flushing unverified when intrusive treap links are rewritten; a shared-account case must confirm reachability, exactly-once scheduling, and successful fd_pack_verify after transfer.

_{Review effort: Balanced}

🔵 Needs a closer look

The tests lack a multi-transaction auction flush case covering shared-account penalty treaps, leaving transaction reachability and exactly-once scheduling unverified when reinsertion rewrites treap links.

_{Review effort: Balanced}

🔵 Needs a closer look

The regression test does not cover ending an auction with multiple held transactions, leaving destructive traversal and pending/penalty treap reinsertion untested.

_{Review effort: Balanced}

🔵 Needs a closer look

The new scheduler’s pacing, bundle timing, CU-rebate interactions, and slot transitions still need tile-level runtime validation beyond the added hold-queue tests.

_{Review effort: Balanced}

🔵 Needs a closer look

The timing-sensitive scheduler changes CU pacing, bundle handling, and slot transitions, but tests cover only queue mechanics, leaving scheduler interactions dependent on domain review and realistic runtime validation.

_{Review effort: Balanced}

🔵 Needs a closer look

The added test covers queue lifecycle only, leaving timing-sensitive auction pacing, bundle bursts, CU rebates, and slot-boundary behavior across multiple execle tiles in need of validator-level validation.

_{Review effort: Balanced}